647a4751 by astaxie

httplib: fix the header function for User-Agent

1 parent f7cd1479
...@@ -355,7 +355,7 @@ func (b *BeegoHttpRequest) getResponse() (*http.Response, error) { ...@@ -355,7 +355,7 @@ func (b *BeegoHttpRequest) getResponse() (*http.Response, error) {
355 Jar: jar, 355 Jar: jar,
356 } 356 }
357 357
358 if b.setting.UserAgent != "" { 358 if b.setting.UserAgent != "" && b.req.Header.Get("User-Agent") == "" {
359 b.req.Header.Set("User-Agent", b.setting.UserAgent) 359 b.req.Header.Set("User-Agent", b.setting.UserAgent)
360 } 360 }
361 361
......
...@@ -203,3 +203,13 @@ func TestToFile(t *testing.T) { ...@@ -203,3 +203,13 @@ func TestToFile(t *testing.T) {
203 t.Fatal(err) 203 t.Fatal(err)
204 } 204 }
205 } 205 }
206
207 func TestHeader(t *testing.T) {
208 req := Get("http://httpbin.org/headers")
209 req.Header("User-Agent", "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.57 Safari/537.36")
210 str, err := req.String()
211 if err != nil {
212 t.Fatal(err)
213 }
214 t.Log(str)
215 }
......
Styling with Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!